Improve some use of Regex #68961
Merged
Improve some use of Regex #68961
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
stephentoub
commented
May 6, 2022
stephentoub
commented
- Use IsMatch instead of Match(...).Success
- Use EnumerateMatches when Index/Length are needed but not captures
- Remove Regex that could just be IndexOf
- Regex.Match never returns null, so remove null checks
|
I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label. |
|
Tagging subscribers to this area: @dotnet/area-system-text-regularexpressions Issue Details
|
joperezr
reviewed
May 6, 2022
...entModel.Annotations/src/System/ComponentModel/DataAnnotations/RegularExpressionAttribute.cs
Outdated
Show resolved
Hide resolved
joperezr
approved these changes
May 6, 2022
Member
joperezr
left a comment
joperezr
left a comment
There was a problem hiding this comment.
Left a small comment but looks good otherwise. I wonder if we should add another analyzer that suggests IsMatch for people that are only doing Match().Success
Member
|
Lol just saw you logged #68962 this morning, so that covers my comment about probably wanting an analyzer 😆 |
stephentoub
force-pushed
the
improveregexusage
branch
from
8853c4e to
237cb68
Compare
- Use IsMatch instead of Match(...).Success - Use EnumerateMatches when Index/Length are needed but not captures - Remove Regex that could just be IndexOf
stephentoub
force-pushed
the
improveregexusage
branch
from
f300021 to
5ab089a
Compare
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.