Do not fold relocatable constants into displacements #68851
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The code in "genCreateAddrMode" was performing the equivalent of constant folding ADDs, but failing to take into account the legality of doing that.
ghost
added
area-CodeGen-coreclr
|
Tagging subscribers to this area: @JulieLeeMSFT Issue DetailsWhen creating address modes, we try to look through cascading N009 ( 9, 11) [000009] ---XG------ * RETURN int
N008 ( 8, 10) [000008] ---XG------ \--* IND ushort
N007 ( 5, 8) [000007] -------N--- \--* ADD byref
N003 ( 3, 6) [000015] ----------- +--* ADD byref
N001 ( 1, 1) [000014] ----------- | +--* CNS_INT long 12 field offset Fseq[_firstChar]
N002 ( 1, 4) [000016] H---------- | \--* CNS_INT(h) ref 0x420068 [ICON_STR_HDL]
N006 ( 2, 2) [000006] -------N--- \--* LSH long
N004 ( 1, 1) [000003] ----------- +--* LCL_VAR long V00 arg0 u:1 (last use)
N005 ( 1, 1) [000005] ----------- \--* CNS_INT long 1We cannot fold such "constants" into Should fix the crashes seen in #68739. No diffs are expected.
|
SingleAccretion
force-pushed
the
Fix-genCreateAddrMode-Handles
branch
from
3bc12e4 to
8a9d859
Compare
Contributor
Author
jakobbotsch
approved these changes
May 5, 2022
Member
jakobbotsch
left a comment
jakobbotsch
left a comment
There was a problem hiding this comment.
LGTM, the TP impact looks insignificant to me.
Contributor
Author
|
The Mono AOT failure looks like #57361, presumably exposed by the recently merged #68288: |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When creating address modes, we try to look through cascading
ADDs with constants that could contribute to the final displacement (LEAs "offset"). In doing so, we were failing to take into account the possibility that said constants could be relocatable handles, such as[000016]in the following tree:We cannot fold such "constants" into
LEAs, this change makes the address mode forming logic respect that.Should fix the crashes seen in #68739.
No diffs are expected.