Tweak Regex comparison to improve subsequent bounds check removals #68846
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stephentoub
added
area-System.Text.RegularExpressions
tenet-performance
ghost
assigned
|
Tagging subscribers to this area: @dotnet/area-system-text-regularexpressions Issue Detailscc: @GrabYourPitchforks, @joperezr
|
stephentoub
force-pushed
the
regexboundscheck
branch
from
3af9707 to
f2a165d
Compare
joperezr
reviewed
May 5, 2022
src/libraries/System.Text.RegularExpressions/gen/RegexGenerator.Emitter.cs
Outdated
Show resolved
Hide resolved
stephentoub
force-pushed
the
regexboundscheck
branch
from
f2a165d to
631c969
Compare
Member
Author
|
I added a comment. I also noticed that we didn't actually need this check at all in some circumstances, so I made it conditional, and when we do emit it, I tweaked the bound to match exactly to the offset that will be used for one of the subsequent checks, since at least today the only one the JIT will eliminate in this situation is one with exactly the same index. |
joperezr
approved these changes
May 5, 2022
Member
joperezr
left a comment
joperezr
left a comment
There was a problem hiding this comment.
Sorry, I thought I had approved already with a comment but apparently not.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc: @GrabYourPitchforks, @joperezr