Remove REGEX_OPTIONS from TextFieldParser.vb #68766
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RegexOptions.CultureInvariant is a nop unless RegexOptions.IgnoreCase is specified or the inline `(?i)` is used in the pattern, neither of which is done here.
ghost
assigned
|
Tagging subscribers to this area: @cston Issue DetailsRegexOptions.CultureInvariant is a nop unless RegexOptions.IgnoreCase is specified or the inline
|
Member
Author
It could, though it'd be hard for an analyzer to accurately handle most of these cases, anywhere the pattern isn't constant (since |
cston
reviewed
May 2, 2022
src/libraries/Microsoft.VisualBasic.Core/src/Microsoft/VisualBasic/FileIO/TextFieldParser.vb
Show resolved
Hide resolved
cston
approved these changes
May 2, 2022
joperezr
approved these changes
May 2, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RegexOptions.CultureInvariant is a nop unless RegexOptions.IgnoreCase is specified or the inline
(?i)is used in the pattern, neither of which is done here.