Avoid string-related allocation from GetCSharpString in XML serializer #68738
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned
danmoseley
approved these changes
May 1, 2022
Member
danmoseley
left a comment
danmoseley
left a comment
There was a problem hiding this comment.
assuming there is indeed no need for the escaping, the change looks good.
Member
|
Presumably when the values are read, they're either unescaped or not. If the former, this breaks them, if the latter then the code is already broken and presumably missing tests? |
…arpString - If there's nothing to escape, we can just return the original string without creating a StringBuilder - These strings are typically very short. We can use ValueStringBuilder and stack space.
stephentoub
force-pushed
the
xmlcsharpstring
branch
from
fe54fb7 to
ddc53e3
Compare
Member
Author
|
I've removed the second commit; I still don't know why the C#-escaping is there, but we can bank the benefits of the first commit and discuss the need for the method at all separately. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This started with my seeing ~45K of string-related allocations in a profile coming from GetCSharpString, even though most of the strings didn't require escaping; the first commit here addresses that. But then the second commit is me questioning why we even need to be doing any C#-related escaping as part of IL generation and reflection emit. Is there a good reason for it?