Skip to content

Conversation

@stephentoub
Copy link
Member

@stephentoub stephentoub commented Apr 29, 2022

  • Delete some now unnecessary pragmas
  • Enable the new Dictionary.ContainsKey guard rule
  • Address one violation of the new rule

@ghost ghost assigned stephentoub Apr 29, 2022
@ghost
Copy link

ghost commented Apr 29, 2022

I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label.

@ghost
Copy link

ghost commented Apr 29, 2022

Tagging subscribers to this area: @dotnet/area-meta
See info in area-owners.md if you want to be subscribed.

Issue Details
  • Delete some now unnecessary pragmas
  • Enable the new Dictionary.ContainsKey guard rule
  • Address on violation of the new rule
Author: stephentoub
Assignees: stephentoub
Labels:

area-Meta

Milestone: -

- Delete some now unnecessary pragmas
- Enable the new Dictionary.ContainsKey guard rule
- Address on violation of the new rule
Copy link
Contributor

@buyaa-n buyaa-n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@stephentoub stephentoub merged commit 71a73fb into dotnet:main May 1, 2022
@stephentoub stephentoub deleted the updateanalyzers branch May 1, 2022 10:22
@ghost ghost locked as resolved and limited conversation to collaborators May 31, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants