Tweak RegexGenerator scan loop #68560
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cleans up the generated code a bit, removing some unnecessary code: - If TryFindNextPossibleStartingPosition has no information to use to do something helpful, there's no point in emitting it. - Simplify the Scan loop structure - Avoid emitting a minimum length required check if the minimum is 0, as we'll never have a position that fails that check. - Avoid a `return false;` code path in TryFindNextPossibleStartingPosition if it'll never be used.
|
Tagging subscribers to this area: @dotnet/area-system-text-regularexpressions Issue DetailsCleans up the generated code a bit, removing some unnecessary code:
|
joperezr
reviewed
Apr 26, 2022
src/libraries/System.Text.RegularExpressions/gen/RegexGenerator.Emitter.cs
Show resolved
Hide resolved
joperezr
approved these changes
Apr 26, 2022
Member
joperezr
left a comment
joperezr
left a comment
There was a problem hiding this comment.
Left a small question, but other than that this looks good.
Member
Author
|
Thanks for reviewing. |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cleans up the generated code a bit, removing some unnecessary code:
return false;code path in TryFindNextPossibleStartingPosition if it'll never be used.