Increase Span.Reverse test coverage #68493
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… as they are going to share the logic soon
|
Tagging subscribers to this area: @dotnet/area-system-memory Issue DetailsWhile reviewing #64412 I've realized that we need more tests for Since both
|
stephentoub
reviewed
Apr 25, 2022
stephentoub
reviewed
Apr 25, 2022
stephentoub
reviewed
Apr 25, 2022
stephentoub
approved these changes
Apr 25, 2022
Member
stephentoub
left a comment
stephentoub
left a comment
There was a problem hiding this comment.
A few comments to be addressed, but otherwise LGTM.
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While reviewing #64412 I've realized that we need more tests for
Span.Reverse.Since both
Array.ReverseandSpan.Reverseare going to use the same logic, we can't no longer useArray.Reverseto produce the expected output forSpan.Reverse(any bug would go unnoticed)