Enable new CA1311 (ToLower/Upper culture) and CA1852 (seal internal/private types) rules #68268
Conversation
stephentoub
requested review from
MichalStrehovsky and
marek-safar
as code owners
|
Tagging subscribers to this area: @dotnet/area-meta Issue DetailsCA1311 flagged a few issues, all addressed by using ToLowerInvariant/ToUpperInvariant. CA1852 flagged a bunch that previous cleanups around sealing types missed or that are new since. Sealing types then highlighted places where protected or virtual members were being exposed unnecessarily, so those were fixed, too. Adding sealed to things also highlighted some discrepancies in the order of "unsafe sealed" keywords, where the vast majority in the repo were "sealed unsafe", so I fixed the few that weren't.
|
src/libraries/Common/src/System/Net/NTAuthentication.Managed.cs
Outdated
Show resolved
Hide resolved
stephentoub
force-pushed
the
enablenewrules
branch
from
59aaf40 to
77fc490
Compare
.../Microsoft.Extensions.DependencyInjection.Specification.Tests/src/ActivatorUtilitiesTests.cs
Outdated
Show resolved
Hide resolved
src/libraries/Microsoft.Extensions.Http/src/DefaultHttpClientFactory.cs
Outdated
Show resolved
Hide resolved
stephentoub
force-pushed
the
enablenewrules
branch
2 times, most recently
from
12cd5d4 to
ab09bab
Compare
|
Thanks for getting dotnet/roslyn-analyzers#5972 up as well! |
GrabYourPitchforks
left a comment
GrabYourPitchforks
left a comment
There was a problem hiding this comment.
Aside from the failing test (which means one of the sealed changes needs to be reverted?) - it all LGTM, including the ToUpperInvariant/ToLowerInvariant portion.
stephentoub
force-pushed
the
enablenewrules
branch
from
ab09bab to
81b4cbb
Compare
…rivate types) CA1311 flagged a few issues, all addressed by using ToLowerInvariant/ToUpperInvariant. CA1852 flagged a bunch that previous cleanups around sealing types missed or that are new since. Sealing types then highlighted places where protected or virtual members were being exposed unnecessarily, so those were fixed, too. Adding sealed to things also highlighted some discrepancies in the order of "unsafe sealed" keywords, where the vast majority in the repo were "sealed unsafe", so I fixed the few that weren't.
stephentoub
force-pushed
the
enablenewrules
branch
from
81b4cbb to
ed991aa
Compare
ghost
locked as resolved and limited conversation to collaborators
5 participants
CA1311 flagged a few issues, all addressed by using ToLowerInvariant/ToUpperInvariant.
CA1852 flagged a bunch that previous cleanups around sealing types missed or that are new since. Sealing types then highlighted places where protected or virtual members were being exposed unnecessarily, so those were fixed, too. Adding sealed to things also highlighted some discrepancies in the order of "unsafe sealed" keywords, where the vast majority in the repo were "sealed unsafe", so I fixed the few that weren't.