Use generic math to dedup Enumerable.Sum/Average #68226
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tagging subscribers to this area: @dotnet/area-system-linq Issue Detailsnull
|
dakersnar
suggested changes
Apr 19, 2022
Contributor
dakersnar
left a comment
dakersnar
left a comment
There was a problem hiding this comment.
Looks good, very cool how clean this is compared to the old version. It seems to me that there are casting inconsistencies for the Sum float operations, unless I'm missing something.
ghost
added
needs-author-action
stephentoub
force-pushed
the
linqgenericsum
branch
from
02e16b2 to
ac4eb9b
Compare
dakersnar
approved these changes
Apr 20, 2022
Contributor
dakersnar
left a comment
dakersnar
left a comment
There was a problem hiding this comment.
Looks good, thanks for the clarifications and fix.
directhex
pushed a commit
to directhex/runtime
that referenced
this pull request
Apr 21, 2022
* Use generic math in Enumerable.Sum/Average * Address PR feedback
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.