Improving STJ source generator support for record types #68064
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
April 14, 2022 20:06
Improving the analyzer to not flag a warning about init-only properties that are actually constructor parameters. In particular, record types with positional parameters desugar to classes with both a constructor and init-only properties (eg, to support "with" expressions). Since these properties are deserialized via the constructor and not the property setter, they support the fast path and round trip just fine, so the diagonstic analyzer should not raise the SYSLIB1037 warning. Issue 58770
Edit to fix missing semi colon in unit test's CreateCompiliation string Issue 58770
ghost
added
community-contribution
|
Tagging subscribers to this area: @dotnet/area-system-text-json, @gregsdennis Issue DetailsImproving the analyzer to not flag a warning about init-only properties that are actually constructor parameters. In particular, See: Issue 58770
|
|
|
...ies/System.Text.Json/tests/System.Text.Json.SourceGeneration.Unit.Tests/CompilationHelper.cs
Outdated
Show resolved
Hide resolved
src/libraries/System.Text.Json/gen/JsonSourceGenerator.Parser.cs
Outdated
Show resolved
Hide resolved
eiriktsarpalis
approved these changes
Apr 18, 2022
Member
eiriktsarpalis
left a comment
eiriktsarpalis
left a comment
There was a problem hiding this comment.
Thank you for your contribution!
directhex
pushed a commit
to directhex/runtime
that referenced
this pull request
Apr 21, 2022
* Improving STJ source generator support for record types Improving the analyzer to not flag a warning about init-only properties that are actually constructor parameters. In particular, record types with positional parameters desugar to classes with both a constructor and init-only properties (eg, to support "with" expressions). Since these properties are deserialized via the constructor and not the property setter, they support the fast path and round trip just fine, so the diagonstic analyzer should not raise the SYSLIB1037 warning. Issue 58770 * Improving STJ source generator support for record types Edit to fix missing semi colon in unit test's CreateCompiliation string Issue 58770 * Case insensitive matching of props with ctor params * Additional unit tests * Test for source gen positional records roundtrip Co-authored-by: Joe Harjung <[email protected]>
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improving the analyzer to not flag a warning about init-only properties that are actually constructor parameters. In particular,
record types with positional parameters desugar to classes with both a constructor and init-only properties (eg, to support "with" expressions). Since these properties are deserialized via the constructor and not the property setter, they support the fast path and round trip just fine, so the diagnostic analyzer should not raise the SYSLIB1037 warning.
See: Issue 58770