-
Notifications
You must be signed in to change notification settings - Fork 5.3k
Expose the GetShortestBitLength, GetByteCount, and WriteLittleEndian APIs #67939
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Note regarding the This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, to please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change. |
|
I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label. |
|
Tagging subscribers to this area: @dotnet/area-system-numerics Issue Detailsnull
|
dakersnar
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
src/libraries/System.Runtime/tests/System/ByteTests.GenericMath.cs
Outdated
Show resolved
Hide resolved
|
Worked around some test failures (and logged corresponding issues). Also fixed an error where these APIs shouldn't be on float/double/decimal/Half. The floating-point types are getting separate APIs to get the exponent and significand instead, so that the value can be understood. |
d5942ee to
5077eb9
Compare
5077eb9 to
15e7ccb
Compare
|
Merge with main to pickup #68058 |
Still pending are the equivalent APIs for getting the exponent/significand for floating-point numbers and the Create* API changes, will be in follow up PRs to help keep size down