-
Notifications
You must be signed in to change notification settings - Fork 5.3k
Add MemoryExtensions.CommonPrefixLength #67929
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Note regarding the This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, to please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change. |
|
Tagging subscribers to this area: @dotnet/area-system-memory Issue DetailsFixes #64271
|
src/libraries/System.Private.CoreLib/src/System/MemoryExtensions.cs
Outdated
Show resolved
Hide resolved
6ff2ed3 to
2a61a6e
Compare
src/libraries/System.Private.CoreLib/src/System/MemoryExtensions.cs
Outdated
Show resolved
Hide resolved
adamsitnik
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@stephentoub thank you! PTAL at my comments
src/libraries/System.Private.CoreLib/src/System/MemoryExtensions.cs
Outdated
Show resolved
Hide resolved
src/libraries/System.Private.Xml/src/System/Xml/Core/XmlTextReaderImpl.cs
Outdated
Show resolved
Hide resolved
src/libraries/System.Private.Xml/src/System/Xml/Core/XmlTextReaderImpl.cs
Outdated
Show resolved
Hide resolved
bf154a4 to
ad5b1f6
Compare
|
I'm uncertain, but this might be the cause of this memory-related regression on Windows x86: dotnet/perf-autofiling-issues#4708 |
Very unlikely, as this just added a new method, and while it was used in a few places, none are related to that benchmark. Also, looking at the current graph, it seems like there were some wild fluctustions but then things went back to normal? |
Fixes #64271