Revert Vector.Equals optimization #67202 #67902
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
area-CodeGen-coreclr
|
Tagging subscribers to this area: @JulieLeeMSFT |
Member
Author
Member
Which CPUs and how significant was it faster by? |
tannergooding
approved these changes
Apr 13, 2022
Member
Author
I don't have access to that CPU but afair it was 5% faster on Ryzen 5950x, you can try this benchmark to check it locally 🙂 https://gist.github.com/EgorBo/bdd35a88a78340c996be7cd236be4805 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR partially reverts #67202 to fix #67596 perf regression
(on some CPUs I tested
xor+vptestwas faster though)PTAL @dotnet/jit-contrib