avoid using TcpClient in FtpWebRequest #67881
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tagging subscribers to this area: @dotnet/ncl Issue DetailsTo point made in #63162 - TcpClient is really useless in most cases. In this case it really does not provide anything beyond
|
gfoidl
reviewed
Apr 12, 2022
src/libraries/System.Net.Requests/src/System/Net/FtpWebRequest.cs
Outdated
Show resolved
Hide resolved
| int port = _uri.Port; | ||
|
|
||
| TcpClient client = new TcpClient(); | ||
| var client = new Socket(SocketType.Stream, ProtocolType.Tcp); ; |
Member
There was a problem hiding this comment.
Suggested change
| var client = new Socket(SocketType.Stream, ProtocolType.Tcp); ; | |
| var client = new Socket(SocketType.Stream, ProtocolType.Tcp); |
src/libraries/System.Net.Requests/src/System/Net/FtpWebRequest.cs
Outdated
Show resolved
Hide resolved
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To point made in #63162 - TcpClient is really useless in most cases. In this case it really does not provide anything beyond
GetStream()and it costs extra object to be allocated.