Revert "Do not generate TYP_STRUCT LCL_FLD nodes (#66251)"
#67360
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 2453f16.
ghost
added
area-CodeGen-coreclr
|
Tagging subscribers to this area: @JulieLeeMSFT Issue DetailsIn #66251 I've enhanced This was a correctness fix. Unfortunately, it also broke the ***** BB01, STMT00006(before)
N005 ( 10, 8) [000064] -A------R--- * ASG long
N004 ( 3, 2) [000062] D------N---- +--* LCL_VAR long V04 tmp2 d:2
N003 ( 6, 5) [000063] n----------- \--* IND long
N002 ( 3, 3) [000043] ------------ \--* ADDR byref Zero Fseq[a]
N001 ( 3, 2) [000044] -------N---- \--* LCL_VAR struct<TestUnsafeCasts+largeStruct, 32> V00 loc0 u:6 (last use)Where the field So I am reverting #66251, it seems
|
Contributor
Author
|
@dotnet/jit-contrib |
EgorBo
approved these changes
Mar 30, 2022
BruceForstall
approved these changes
Mar 30, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #66251 I've enhanced
IsLocalAddrExprto look for zero-offset sequences onADDRs.This was a correctness fix.
Unfortunately, it also broke the
structreturntest because we have the following tree there:Where the field
adoes not belong toTestUnsafeCasts+largeStruct. This is the well-known VN problem with invalid field sequences, there is no expedient fix for it.So I am reverting #66251, it seems
TYP_STRUCTLCL_FLDis fully gated on fixing this problem (I knew it was gated at least partially, I did not anticipate it to break so quickly though).Fixes #67346, #67355.