LoggingSourceGenerator - Fixes InvalidCastException when using other attributes#67179
Merged
maryamariyan merged 1 commit intodotnet:mainfrom Mar 26, 2022
Merged
LoggingSourceGenerator - Fixes InvalidCastException when using other attributes#67179maryamariyan merged 1 commit intodotnet:mainfrom
maryamariyan merged 1 commit intodotnet:mainfrom
Conversation
- alongside LoggerMessageAttribute Fixes dotnet#67167
|
Tagging subscribers to this area: @dotnet/area-extensions-logging Issue Details
Fixes #67167
|
tarekgh
approved these changes
Mar 26, 2022
eerhardt
reviewed
Mar 28, 2022
| ImmutableArray<AttributeData>? boundAttributes = logMethodSymbol?.GetAttributes(); | ||
|
|
||
| if (boundAttrbutes == null) | ||
| if (boundAttributes == null || boundAttributes!.Value.Length == 0) |
Member
There was a problem hiding this comment.
Why did you need a ! here? You just checked it for null on the same line.
radekdoulik
pushed a commit
to radekdoulik/runtime
that referenced
this pull request
Mar 30, 2022
- alongside LoggerMessageAttribute Fixes dotnet#67167
ghost
locked as resolved and limited conversation to collaborators
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #67167