Skip to content

Conversation

@CodeBlanch
Copy link
Contributor

For value types avoids an extra copy of T in MoveNext. Copy is still made in Current.

/cc @stephentoub @noahfalk @tarekgh

@ghost ghost added area-System.Diagnostics.Tracing community-contribution Indicates that the PR has been added by a community member labels Mar 22, 2022
@ghost
Copy link

ghost commented Mar 22, 2022

Tagging subscribers to this area: @tarekgh, @tommcdon, @pjanotti
See info in area-owners.md if you want to be subscribed.

Issue Details

For value types avoids an extra copy of T in MoveNext. Copy is still made in Current.

/cc @stephentoub @noahfalk @tarekgh

Author: CodeBlanch
Assignees: -
Labels:

area-System.Diagnostics.Tracing, community-contribution

Milestone: -

@ghost
Copy link

ghost commented Mar 22, 2022

Tagging subscribers to this area: @dotnet/area-system-diagnostics-activity
See info in area-owners.md if you want to be subscribed.

Issue Details

For value types avoids an extra copy of T in MoveNext. Copy is still made in Current.

/cc @stephentoub @noahfalk @tarekgh

Author: CodeBlanch
Assignees: -
Labels:

area-System.Diagnostics.Activity, community-contribution

Milestone: -

@tarekgh tarekgh added this to the 7.0.0 milestone Mar 22, 2022
Copy link
Member

@tarekgh tarekgh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @CodeBlanch

@danmoseley danmoseley merged commit c5d40c9 into dotnet:main Mar 23, 2022
@CodeBlanch CodeBlanch deleted the activity-enumerator-copy branch March 23, 2022 23:55
radekdoulik pushed a commit to radekdoulik/runtime that referenced this pull request Mar 30, 2022
@EgorBo
Copy link
Member

EgorBo commented Apr 7, 2022

Nice improvement on windows-x64 dotnet/perf-autofiling-issues#4308, dotnet/perf-autofiling-issues#4283 (ubuntu-x64)

@ghost ghost locked as resolved and limited conversation to collaborators May 7, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-System.Diagnostics.Activity community-contribution Indicates that the PR has been added by a community member

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants