Update to latest System.CommandLine package#66929
Merged
jkotas merged 1 commit intodotnet:mainfrom Mar 21, 2022
Merged
Conversation
jkotas
force-pushed
the
System.CommandLine
branch
from
0bc0092 to
d5e7131
Compare
Member
Author
|
/azp run runtime-coreclr crossgen2 outerloop |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Member
Member
|
Considering we've been churning this bit for the last two and a half years, should we at least wait until System.CommandLine proceeds from the "beta" phase to some real shipping version? |
Member
Author
|
The System.CommandLine APIs have changed since 4731fdb so it would not be a simple revert. It would nice to give it a try and measure the performance, give feedback to System.CommandLine team if it is still slowing down crossgen2 too much. |
radekdoulik
pushed a commit
to radekdoulik/runtime
that referenced
this pull request
Mar 30, 2022
ghost
locked as resolved and limited conversation to collaborators
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.