-
Notifications
You must be signed in to change notification settings - Fork 5.4k
Fixes #42643 allow keys with colons in JSON config #66886
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
SteveDunn
wants to merge
17
commits into
dotnet:main
from
SteveDunn:42643-bind-to-json-containing-keys-with-colons
Closed
Changes from all commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
03312e5
42643 Work in Progress attempt at getting this to work. Note - hard-c…
SteveDunn 712b165
Can now have colons in keys in json, but it still breaks other tests.…
SteveDunn cd82ca5
Got backtick separator working for json provider.
SteveDunn ac6868c
Fixed separator - now all json tests pass,although combinations are b…
SteveDunn 98abb13
Fixed all but 1 test
SteveDunn ef1b22d
All tests pass, although `GetChildrenImplementation` is still a mess
SteveDunn cab595d
Tidy up (somewhat) `GetChildrenImplementation` to cater for the fact …
SteveDunn cf11662
Tidy
SteveDunn 1b8dad0
Tidy
SteveDunn 914b5f0
PR feedback - duplicate signatures rather than use default parameters
SteveDunn 1d866cf
Tidy up and fix issue where default delimiter was used for sorting
SteveDunn 1c9565d
Removed code that should've been removed previously as part of the cl…
SteveDunn 04fd249
PR feedback: ran dotnet msbuild /t:GenerateReferenceAssemblySource to…
SteveDunn 01785b6
Remove commented code
SteveDunn 0cbd086
Remove extra blank line
SteveDunn 5a12e85
Merge branch 'main' into 42643-bind-to-json-containing-keys-with-colons
SteveDunn 5374c6f
Post merge: delimiter is now per-instance in comparer rather than static
SteveDunn File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.