Remove superfluous string[] and string from System.IO.Packaging.ContentType #66764
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/libraries/System.IO.Packaging/src/System/IO/Packaging/ContentType.cs
Show resolved
Hide resolved
AaronRobinsonMSFT
approved these changes
Mar 17, 2022
|
Tagging subscribers to this area: @dotnet/area-system-io-compression Issue DetailsRelated to dotnet/wpf#6268
|
Contributor
|
Has any special meaning?, otherwise search/replace with |
Member
Author
Purely a guess, but I'd speculate someone meant to write "character", instead had a typo and wrote "characeter", and a well-meaning tool decided to remove a potentially sensitive substring, leaving "cha----ter". Feel free to submit a PR to clean it up. |
adamsitnik
approved these changes
Mar 18, 2022
Member
adamsitnik
left a comment
adamsitnik
left a comment
There was a problem hiding this comment.
LGTM, thank you @stephentoub
src/libraries/System.IO.Packaging/src/System/IO/Packaging/ContentType.cs
Show resolved
Hide resolved
src/libraries/System.IO.Packaging/src/System/IO/Packaging/ContentType.cs
Show resolved
Hide resolved
src/libraries/System.IO.Packaging/src/System/IO/Packaging/ContentType.cs
Show resolved
Hide resolved
radekdoulik
pushed a commit
to radekdoulik/runtime
that referenced
this pull request
Mar 30, 2022
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to dotnet/wpf#6268