Reduce string allocations in XmlWriterTraceListener #66762
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rather than ToString'ing everything, most of the header data can be formatted into a span and then written out to the writer.
|
Tagging subscribers to this area: @dotnet/area-system-xml Issue DetailsRather than ToString'ing everything, most of the header data can be formatted into a span and then written out to the writer. using BenchmarkDotNet.Attributes;
using BenchmarkDotNet.Running;
using System.Diagnostics;
using System.IO;
[MemoryDiagnoser]
public class Program
{
static void Main(string[] args) => BenchmarkSwitcher.FromAssembly(typeof(Program).Assembly).Run(args);
private XmlWriterTraceListener _listener = new XmlWriterTraceListener(Stream.Null);
private TraceEventCache _cache = new TraceEventCache();
[Benchmark]
public void Trace()
{
_listener.TraceEvent(_cache, "something", TraceEventType.Information, 42);
}
}
|
danmoseley
approved these changes
Mar 18, 2022
radekdoulik
pushed a commit
to radekdoulik/runtime
that referenced
this pull request
Mar 30, 2022
Rather than ToString'ing everything, most of the header data can be formatted into a span and then written out to the writer.
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rather than ToString'ing everything, most of the header data can be formatted into a span and then written out to the writer.