Dedup patterm/options/timeout in Regex source generator #66747
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If we end up with multiple identical pattern/options/timeout tuples in the same assembly, we don't need to emit unique code for each. We can still emit the partial implementation for each, but emit a single implementation of the Regex they all share.
No reason we need a property here wrapping a compiler-generated backing field.
|
Tagging subscribers to this area: @dotnet/area-system-text-regularexpressions Issue DetailsIf we end up with multiple identical pattern/options/timeout tuples in the same assembly, we don't need to emit unique code for each. We can still emit the partial implementation for each, but emit a single implementation of the Regex they all share.
|
danmoseley
approved these changes
Mar 17, 2022
radekdoulik
pushed a commit
to radekdoulik/runtime
that referenced
this pull request
Mar 30, 2022
* Dedup patterm/options/timeout in Regex source generator If we end up with multiple identical pattern/options/timeout tuples in the same assembly, we don't need to emit unique code for each. We can still emit the partial implementation for each, but emit a single implementation of the Regex they all share. * Make the cached Regex members be static readonly fields No reason we need a property here wrapping a compiler-generated backing field.
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we end up with multiple identical pattern/options/timeout tuples in the same assembly, we don't need to emit unique code for each. We can still emit the partial implementation for each, but emit a single implementation of the Regex they all share.