Implement missing SymUnmanaged* interfaces #66650
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
area-NativeAOT-coreclr
community-contribution
hez2010
commented
Mar 15, 2022
src/coreclr/tools/Common/TypeSystem/Ecma/SymbolReader/UnmanagedPdbSymbolReader.cs
Show resolved
Hide resolved
hez2010
commented
Mar 15, 2022
src/coreclr/tools/Common/TypeSystem/Ecma/SymbolReader/UnmanagedPdbSymbolReader.cs
Show resolved
Hide resolved
hez2010
commented
Mar 16, 2022
src/coreclr/tools/Common/TypeSystem/Ecma/SymbolReader/UnmanagedPdbSymbolReader.cs
Outdated
Show resolved
Hide resolved
jkotas
reviewed
Mar 16, 2022
src/coreclr/tools/Common/TypeSystem/Ecma/SymbolReader/UnmanagedPdbSymbolReader.cs
Outdated
Show resolved
Hide resolved
jkotas
reviewed
Mar 16, 2022
src/coreclr/tools/Common/TypeSystem/Ecma/SymbolReader/UnmanagedPdbSymbolReader.cs
Outdated
Show resolved
Hide resolved
hez2010
force-pushed
the
nativeaot/sym-interface
branch
from
f3860d8 to
b92ad36
Compare
Member
|
@jkotas Anything else you wanted to look at? |
radekdoulik
pushed a commit
to radekdoulik/runtime
that referenced
this pull request
Mar 30, 2022
* Implement missing SymUnmanaged* interfaces * Add try-finally around GCHandle * Marshal interface argument to pinned pointer * Minor fixes * Address feedbacks from review
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements missing RCW COMWrappers for SymUnmanaged* interfaces required by compiling BenchmarkDotNet with NativeAOT.
Fixes #66637
/cc: @agocke