Fix KeepNativeSymbols to work on mono as well #66594
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When packaging .NET on s390x through source-build, we want to keep debug symbols enabled in the build. The package manager (debbuild, rpmbuild, etc) generally strips the binaries to create distro-standard -debug/-debuginfo packages. This was supported in coreclr via --keepnativesymbols flag, but wasn't supported in mono (ie, s390x). Fix that.
ghost
added
area-Build-mono
community-contribution
Member
Author
|
@uweigand I only tested this on x64, can you help me confirm that this works on s390x as well? I have been building with And looking at the presence of debug symbols in "libcoreclr.so" |
Member
Author
|
I have verified this on s390x. The mono llvmfullaot errors look unrelated, can anyone confirm? |
Member
Author
|
@marek-safar @uweigand can you please take a look at this? |
Contributor
|
@directhex how does this look to you? |
Member
Author
|
Ping. Any review/feedback would be nice. We have included this change for our 6.0 builds on RHEL/CentOS already: https://git.centos.org/rpms/dotnet6.0/blob/3afb15f24b3fc61da3d56a3e8269f85d084cb71a/f/SOURCES/runtime-66594-s390x-debuginfo.patch |
Member
Author
|
Any thoughts, @directhex? |
directhex
approved these changes
May 16, 2022
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When packaging .NET on s390x through source-build, we want to keep debug
symbols enabled in the build. The package manager (debbuild, rpmbuild,
etc) generally strips the binaries to create distro-standard
-debug/-debuginfo packages. This was supported in coreclr via
--keepnativesymbols flag, but wasn't supported in mono (ie, s390x). Fix
that.