Add Stopwatch.GetElapsedTime #66372
Add Stopwatch.GetElapsedTime #66372
Conversation
|
Note regarding the This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, to please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change. |
ghost
added
the
|
I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label. |
stephentoub
force-pushed
the
stopwatchgetelapsedtime
branch
from
866874e to
f118d26
Compare
| /// <param name="endingTimestamp">The timestamp marking the end of the time period.</param> | ||
| /// <returns>A <see cref="TimeSpan"/> for the elapsed time between the starting and ending timestamps.</returns> | ||
| public static TimeSpan GetElapsedTime(long startingTimestamp, long endingTimestamp) => | ||
| new TimeSpan((long)((endingTimestamp - startingTimestamp) * s_tickFrequency)); |
There was a problem hiding this comment.
An unrelated question about s_tickFrequency
On Unix, we use a constant 1000000000 for frequency calculation, while on Windows we call Kernel32.QueryPerformanceFrequency()). Would it make sense to align them? e.g. making it constant for Windows as well, or implementing frequency shim on Unix; something like:
int64_t SystemNative_GetPerformanceCounterFrequency()
{
const int64_t defaultFrequency = 1000000000;
struct timespec spec;
if (clock_getres(CLOCK_MONOTONIC, &spec) != 0) return defaultFrequency;
assert(spec.tv_sec < 1); // resolution in seconds is too high to be correct
assert(spec.tv_nsec > 0);
return defaultFrequency / spec.tv_nsec;
}There was a problem hiding this comment.
It used to call into a native shim. It was changed in #43343.
There was a problem hiding this comment.
For reference, Unix always returns something in terms of seconds + nanoseconds. Where-as Windows returns a measurement in unknown units where you have to independently query a frequency to convert it to nanoseconds.
The static APIs on Stopwatch are meant to be minimal overhead and directly return the "raw units" given by the underlying OS functions. This new helper is what allows it to be normalized to TimeSpan units, which are in terms of 100ns ticks.
4 participants
Fixes #65858