[Mono] Add intrinsics for several operators #66317
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vargaz
approved these changes
Mar 8, 2022
fanyang-mono
reviewed
Mar 8, 2022
fanyang-mono
changed the title
Member
|
@vargaz Could you please review again? |
| case SN_op_ExclusiveOr: | ||
| case SN_op_Multiply: | ||
| case SN_op_Subtraction: { | ||
| if (fsig->param_count != 2 ) |
Member
There was a problem hiding this comment.
Will have a follow-up PR to fix the extra space.
| g_assert (fsig->param_count == 2 && fsig->ret->type == MONO_TYPE_BOOLEAN && | ||
| mono_metadata_type_equal (fsig->params [0], type) && | ||
| mono_metadata_type_equal (fsig->params [1], type)); | ||
| if (fsig->param_count != 2 ) |
| } | ||
| case SN_op_OnesComplement: | ||
| case SN_op_UnaryNegation: | ||
| if (fsig->param_count != 1 ) |
Member
|
The failures on CI are irrelevant to this PR. |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contributes to #64072
Added intrinsics for following operators