Fixes Binding to non-null IEnumerable doesn't work #36390 #66131
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
area-Extensions-Configuration
community-contribution
|
Tagging subscribers to this area: @dotnet/area-extensions-configuration Issue DetailsFixes Binding to non-null IEnumerable doesn't work #36390
|
maryamariyan
reviewed
Mar 3, 2022
src/libraries/Microsoft.Extensions.Configuration.Binder/tests/ConfigurationBinderTests.cs
Outdated
Show resolved
Hide resolved
maryamariyan
reviewed
Mar 3, 2022
src/libraries/Microsoft.Extensions.Configuration.Binder/tests/ConfigurationBinderTests.cs
Outdated
Show resolved
Hide resolved
maryamariyan
suggested changes
Mar 3, 2022
src/libraries/Microsoft.Extensions.Configuration.Binder/src/ConfigurationBinder.cs
Outdated
Show resolved
Hide resolved
src/libraries/Microsoft.Extensions.Configuration.Binder/src/ConfigurationBinder.cs
Outdated
Show resolved
Hide resolved
src/libraries/Microsoft.Extensions.Configuration.Binder/src/ConfigurationBinder.cs
Outdated
Show resolved
Hide resolved
ghost
added
the
needs-author-action
SteveDunn
force-pushed
the
bind-non-null-ienumerable
branch
from
3918952 to
c9ef81a
Compare
ghost
removed
the
needs-author-action
Cater for indrectly derived instances of IEnumerable<T> in fields.
SteveDunn
commented
Mar 3, 2022
src/libraries/Microsoft.Extensions.Configuration.Binder/src/ConfigurationBinder.cs
Outdated
Show resolved
Hide resolved
src/libraries/Microsoft.Extensions.Configuration.Binder/src/ConfigurationBinder.cs
Outdated
Show resolved
Hide resolved
src/libraries/Microsoft.Extensions.Configuration.Binder/src/ConfigurationBinder.cs
Outdated
Show resolved
Hide resolved
src/libraries/Microsoft.Extensions.Configuration.Binder/tests/ConfigurationBinderTests.cs
Outdated
Show resolved
Hide resolved
src/libraries/Microsoft.Extensions.Configuration.Binder/tests/ConfigurationBinderTests.cs
Outdated
Show resolved
Hide resolved
...aries/Microsoft.Extensions.Configuration.Binder/tests/ConfigurationCollectionBindingTests.cs
Show resolved
Hide resolved
Contributor
@SteveDunn the ones you addressed you could mark as resolved. Also note, the blank line is still in the diff, you'd want to reconfirm if the commit/changes you wanted is showing up in the PR through the diff tab. |
maryamariyan
added
the
needs-author-action
ghost
removed
the
needs-author-action
maryamariyan
approved these changes
Mar 15, 2022
Contributor
maryamariyan
left a comment
maryamariyan
left a comment
There was a problem hiding this comment.
Overall LGTM, but there's some nit changes to be addressed. I think your branch is not in sync with what's present in the PR diff
src/libraries/Microsoft.Extensions.Configuration.Binder/src/ConfigurationBinder.cs
Outdated
Show resolved
Hide resolved
...aries/Microsoft.Extensions.Configuration.Binder/tests/ConfigurationCollectionBindingTests.cs
Outdated
Show resolved
Hide resolved
...aries/Microsoft.Extensions.Configuration.Binder/tests/ConfigurationCollectionBindingTests.cs
Outdated
Show resolved
Hide resolved
…ConfigurationCollectionBindingTests.cs
…ConfigurationCollectionBindingTests.cs
maryamariyan
approved these changes
Mar 15, 2022
tarekgh
approved these changes
Mar 15, 2022
Contributor
Author
@maryamariyan - should all be OK now. |
halter73
approved these changes
Mar 15, 2022
Member
|
Thanks @SteveDunn! |
Contributor
|
merged now. @SteveDunn this should be available in preview 3. thanks for your contribution! |
radekdoulik
pushed a commit
to radekdoulik/runtime
that referenced
this pull request
Mar 30, 2022
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes Binding to non-null IEnumerable doesn't work #36390