[mono][jit] Transition the x86 backend to use SSE for fp arithmetic.#65723
Merged
vargaz merged 10 commits intodotnet:mainfrom Aug 8, 2022
Merged
[mono][jit] Transition the x86 backend to use SSE for fp arithmetic.#65723vargaz merged 10 commits intodotnet:mainfrom
vargaz merged 10 commits intodotnet:mainfrom
Conversation
vargaz
requested review from
SamMonoRT,
imhameed and
lambdageek
as code owners
Contributor
Author
|
Todo:
|
Contributor
Author
|
/azp run runtime-extra-platforms |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
Author
|
Fixes #65557 |
vargaz
force-pushed
the
x86-sse
branch
4 times, most recently
from
e31abe9 to
51abe71
Compare
Contributor
Author
|
/azp run runtime-extra-platforms |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Member
|
Please also reenable the tests that were disabled with ActiveIssue in src/libraries/System.Runtime.InteropServices/tests/System.Runtime.InteropServices.UnitTests/System/Runtime/InteropServices/NFloatTests.cs |
Contributor
Author
|
/azp run runtime-extra-platforms |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
Author
|
/azp run runtime-extra-platforms |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
Author
|
/azp run runtime-extra-platforms |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
Author
|
/azp run runtime-extra-platforms |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
Author
|
CI failures are unrelated, this PR only affects 32 bit x86. |
Contributor
Author
|
/azp run runtime-extra-platforms |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
Author
|
/azp run runtime-extra-platforms |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
Author
|
/azp run runtime-extra-platforms |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
Author
|
/azp run runtime-extra-platforms |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
Author
|
The failures are fixed now. Should this be in 7.0 ? |
Member
Yea, I think we should take this in 7 |
akoeplinger
added a commit
to akoeplinger/runtime
that referenced
this pull request
Aug 12, 2022
Looks like this got inadvertently broken by dotnet#65723
akoeplinger
added a commit
that referenced
this pull request
Aug 12, 2022
Looks like this got inadvertently broken by #65723
This was referenced Aug 12, 2022
This was referenced Aug 17, 2022
akoeplinger
pushed a commit
that referenced
this pull request
Aug 18, 2022
ghost
locked as resolved and limited conversation to collaborators
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
mini-amd64.c.
Fixes #65557