Add the CustomTypeMarshallerAttribute type to make it easier to identify marshaller types by jkoritzinsky · Pull Request #65591 · dotnet/runtime

jkoritzinsky · 2022-02-18T21:53:19Z

Add a CustomTypeMarshallerAttribute type that goes on the marshaller type to enable us to easily identify marshaller types and provide an easier way for us to analyze and validate the shape of the user-defined marshaller types.

This PR also updates the design docs.

…ify which types are marshaller types to make it easier to version the shape model and help users write shape types.

ghost · 2022-02-18T21:53:28Z

Tagging subscribers to this area: @dotnet/interop-contrib
See info in area-owners.md if you want to be subscribed.

Issue Details

Add a CustomTypeMarshallerAttribute type that goes on the marshaller type to enable us to easily identify marshaller types and provide an easier way for us to analyze and validate the shape of the user-defined marshaller types.

This PR also updates the design docs.

Author:	jkoritzinsky
Assignees:	-
Labels:	`area-System.Runtime.InteropServices`, `source-generator`
Milestone:	7.0.0

…ing-v2

jkoritzinsky · 2022-03-15T18:08:47Z

Failures are #66601, #66571, #66556, and #66672.

@dotnet/interop-contrib this is ready for review

docs/design/libraries/LibraryImportGenerator/SpanMarshallers.md

docs/design/libraries/LibraryImportGenerator/StructMarshalling.md

src/libraries/Common/src/System/Runtime/InteropServices/CustomTypeMarshallerDirection.cs

...s/System.Runtime.InteropServices/gen/LibraryImportGenerator/Analyzers/AnalyzerDiagnostics.cs

…ing-v2

elinor-fung

Generally looks good to me. I think we should run libraries-outerloop on this too, since we know we've affected entire suites in those with no indication in innerloop before.

src/libraries/Common/src/System/Runtime/InteropServices/GeneratedMarshallingAttribute.cs

docs/design/libraries/LibraryImportGenerator/StructMarshalling.md

eng/generators.targets

src/libraries/System.Runtime.InteropServices/gen/LibraryImportGenerator/Resources.resx

...s/System.Runtime.InteropServices/gen/LibraryImportGenerator/Analyzers/AnalyzerDiagnostics.cs

...s/gen/Microsoft.Interop.SourceGeneration/Marshalling/ICustomNativeTypeMarshallingStrategy.cs

src/coreclr/nativeaot/Test.CoreLib/src/Test.CoreLib.csproj

…ing-v2

jkoritzinsky · 2022-03-22T17:19:34Z

Failures are dotnet/roslyn-sdk#974, #59542, and #64964/#66852

jkoritzinsky · 2022-03-22T17:21:52Z

/azp run runtime-libraries-coreclr outerloop

azure-pipelines · 2022-03-22T17:38:12Z

Azure Pipelines successfully started running 1 pipeline(s).

jkoritzinsky · 2022-03-22T21:21:13Z

Test failures from the runtime-libraries-coreclr outerloop pipelines are as follows:

Windows failures are due to deadlettered Helix jobs

System.Security.Cryptography.X509Certificates failures are #66803

Regex failure on OSX is a timeout. Not sure what caused that.

System.Runtime failures on some Linux lanes: I'll try to figure out what's causing those to fail.

jkoritzinsky · 2022-03-22T22:10:35Z

System.Runtime test failures look like #58616

…ify marshaller types (dotnet#65591)

jkoritzinsky added 4 commits February 17, 2022 15:14

Add a CustomTypeMarshallerAttribute to enable us to more easily ident…

7701e47

…ify which types are marshaller types to make it easier to version the shape model and help users write shape types.

Do some renaming to be consistent.

cd04737

Add a placeholder type to support the array marshallers.

1909ae2

Update custom marshalling design docs and the runtime usage

c108257

jkoritzinsky added area-System.Runtime.InteropServices source-generator Indicates an issue with a source generator feature labels Feb 18, 2022

jkoritzinsky added this to the 7.0.0 milestone Feb 18, 2022

jkoritzinsky requested review from AaronRobinsonMSFT and elinor-fung February 18, 2022 21:53

ghost assigned jkoritzinsky Feb 18, 2022

jkoritzinsky added 6 commits February 18, 2022 14:40

Fix test build

b398b64

Fix net6.0 ldap build.

b626108

Fix conditional

2ecc899

Fix DllImportGenerator unit tests

78e9abd

Merge branch 'main' of github.com:dotnet/runtime into custom-marshall…

86c386a

…ing-v2

More test fixes

3104a16

jkoritzinsky force-pushed the custom-marshalling-v2 branch from 8464fa2 to 3104a16 Compare February 22, 2022 23:28

runfoapp bot mentioned this pull request Feb 23, 2022

System.IO.Tests work item failing with SIGKILL #65791

Closed

jkoritzinsky added 2 commits February 28, 2022 10:18

Merge branch 'main' into custom-marshalling-v2

e98a729

Add missing attribute

ec76402

elinor-fung mentioned this pull request Mar 2, 2022

Address TODO to switch to generated p/invoke #66057

Merged

jkoritzinsky added 8 commits March 2, 2022 13:27

Do simple renames to match API review.

91a585c

Get all tests green with the currently approved API design.

dc5969f

Merge branch 'main' of github.com:dotnet/runtime into custom-marshall…

cd0e6e7

…ing-v2

A few misc fixes

bad0de1

Convert custom marshallers in the tree to the approved shape

bae0262

Merge branch 'main' of github.com:dotnet/runtime into custom-marshall…

3f34c8c

…ing-v2

Fix test failure

9b4b1f7

Merge branch 'main' into custom-marshalling-v2

4b67271

Merge branch 'main' into custom-marshalling-v2

59b6732

elinor-fung reviewed Mar 17, 2022

View reviewed changes

jkoritzinsky requested a review from jeffhandley as a code owner March 17, 2022 21:27

PR feedback.

61673ac

jkoritzinsky force-pushed the custom-marshalling-v2 branch from 07803e6 to 61673ac Compare March 17, 2022 21:29

jkoritzinsky added 2 commits March 17, 2022 14:30

Merge branch 'main' of github.com:dotnet/runtime into custom-marshall…

9089b80

…ing-v2

Fix docs.

bd32b16

elinor-fung reviewed Mar 19, 2022

View reviewed changes

MichalStrehovsky reviewed Mar 21, 2022

View reviewed changes

src/coreclr/nativeaot/Test.CoreLib/src/Test.CoreLib.csproj Outdated Show resolved Hide resolved

jkoritzinsky added 4 commits March 21, 2022 14:11

PR feedback

04e8cb1

Merge some diagnostic IDs

8b8d52a

Merge branch 'main' of github.com:dotnet/runtime into custom-marshall…

d1d19b0

…ing-v2

Fix id reference

23613c3

jkoritzinsky requested a review from elinor-fung March 22, 2022 17:19

elinor-fung approved these changes Mar 23, 2022

View reviewed changes

AaronRobinsonMSFT approved these changes Mar 23, 2022

View reviewed changes

jkoritzinsky merged commit a02b49a into dotnet:main Mar 23, 2022

jkoritzinsky deleted the custom-marshalling-v2 branch March 23, 2022 16:06

radekdoulik pushed a commit to radekdoulik/runtime that referenced this pull request Mar 30, 2022

Add the CustomTypeMarshallerAttribute type to make it easier to ident…

969b939

…ify marshaller types (dotnet#65591)

ghost locked as resolved and limited conversation to collaborators Apr 22, 2022

Conversation

jkoritzinsky commented Feb 18, 2022

Uh oh!

ghost commented Feb 18, 2022

Uh oh!

jkoritzinsky commented Mar 15, 2022

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

elinor-fung left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

jkoritzinsky commented Mar 22, 2022

Uh oh!

jkoritzinsky commented Mar 22, 2022

Uh oh!

azure-pipelines bot commented Mar 22, 2022

Uh oh!

jkoritzinsky commented Mar 22, 2022

Uh oh!

jkoritzinsky commented Mar 22, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants