Skip to content

[tests] Extend partial disablement of SkippingHiddenFiles#65280

Merged
adamsitnik merged 1 commit intodotnet:mainfrom
mdh1418:skip_skippinghiddenfiles_dot_windows_server_2022_greater
Feb 14, 2022
Merged

[tests] Extend partial disablement of SkippingHiddenFiles#65280
adamsitnik merged 1 commit intodotnet:mainfrom
mdh1418:skip_skippinghiddenfiles_dot_windows_server_2022_greater

Conversation

@mdh1418
Copy link
Member

@mdh1418 mdh1418 commented Feb 14, 2022 •
edited
Loading 

System.IO.Tests.Enumeration.SpecialDirectoryTests_Enumerable.SkippingHiddenFiles [FAIL]
      Assert.Contains() Failure
      Not found: .
      In value:  String[] [".."]

was hit on Windows Server 2022. Extending the condition applied to Windows 11 to include Windows Server 2022.
#33148

@mdh1418 mdh1418 requested a review from danmoseley February 14, 2022 01:22
@ghost ghost added the area-System.IO label Feb 14, 2022
@ghost ghost assigned mdh1418 Feb 14, 2022
@ghost
Copy link

ghost commented Feb 14, 2022

Tagging subscribers to this area: @dotnet/area-system-io
See info in area-owners.md if you want to be subscribed.

Issue Details 
System.IO.Tests.Enumeration.SpecialDirectoryTests_Enumerable.SkippingHiddenFiles [FAIL]
      Assert.Contains() Failure
      Not found: .
      In value:  String[] [".."]

was hit on Windows Server 2022. Extending the condition applied to Windows 11 to include Windows Server 2022.

Author: mdh1418
Assignees: -
Labels:

area-System.IO
Milestone: -

danmoseley
danmoseley approved these changes Feb 14, 2022
View reviewed changes
Copy link
Member

@danmoseley danmoseley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @mdh1418

adamsitnik
adamsitnik approved these changes Feb 14, 2022
View reviewed changes
Copy link
Member

@adamsitnik adamsitnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you @mdh1418 !

@adamsitnik
Copy link
Member

adamsitnik commented Feb 14, 2022

I've started the re-run of failed CI legs

@adamsitnik adamsitnik merged commit 2026b44 into dotnet:main Feb 14, 2022
@mdh1418 mdh1418 deleted the skip_skippinghiddenfiles_dot_windows_server_2022_greater branch February 21, 2022 19:21
@ghost ghost locked as resolved and limited conversation to collaborators Mar 24, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@adamsitnik adamsitnik adamsitnik approved these changes

@danmoseley danmoseley danmoseley approved these changes

Assignees

@mdh1418 mdh1418

Labels

area-System.IO

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mdh1418 @adamsitnik @danmoseley