[Mono] Add SIMD intrinsic for Vector64/128 comparisons #65128
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simonrozsival
requested review from
SamMonoRT,
imhameed,
lambdageek and
vargaz
as code owners
vargaz
approved these changes
Feb 10, 2022
tannergooding
approved these changes
Feb 10, 2022
Member
Author
|
Failing tests are related to #65818 |
fanyang-mono
approved these changes
Feb 24, 2022
| case SN_Equals: | ||
| case SN_EqualsAll: | ||
| case SN_EqualsAny: { | ||
| MonoType *arg_type = get_vector_t_elem_type (fsig->params [0]); |
Member
There was a problem hiding this comment.
We should start to add comprehensive vector element type checks for each case. (Both input args and the return.) I have a PR up to refactor the code of type checks for this function. (#65486) You could merge this PR like this and fix it with your next PR.
| case SN_GreaterThanOrEqual: | ||
| case SN_LessThan: | ||
| case SN_LessThanOrEqual: { | ||
| MonoType *arg_type = get_vector_t_elem_type (fsig->params [0]); |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contributes to #64072
==and!=