[Mono] Add SIMD intrinsics for Vector{64, 128} on Arm64 Part I #64961
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fanyang-mono
requested review from
SamMonoRT,
lambdageek and
vargaz
as code owners
ghost
added
the
fanyang-mono
changed the title
vargaz
reviewed
Feb 8, 2022
vargaz
reviewed
Feb 8, 2022
simonrozsival
approved these changes
Feb 9, 2022
vargaz
approved these changes
Feb 9, 2022
fanyang-mono
force-pushed
the
arm64_intrinsics_1
branch
from
5a1df48 to
d5a51aa
Compare
Member
Author
|
@imhameed could you take a look at the failure in llvmaot lane here, while I am on vacation? For some reason, the type does match for max intrinsics on x64 with sse. Looks like my fix for that wasn’t sufficient. Thanks in advance! |
fanyang-mono
force-pushed
the
arm64_intrinsics_1
branch
from
c0becc6 to
d9a04de
Compare
Member
Author
|
All lanes are green now. Please review this PR again, since I've made changes after previous approval. @vargaz @imhameed @simonrozsival |
vargaz
reviewed
Feb 14, 2022
vargaz
reviewed
Feb 14, 2022
vargaz
approved these changes
Feb 14, 2022
ihameed
approved these changes
Feb 14, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contributes to #64072
This PR intrinsify the following methods of Vector{64, 128}: