Optimize StringBuilder.Insert.
#64922
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The character array overload calls the ReadOnlySpan overload, and the overloads of primitives call a private helper function that takes advantage of ISpanFormattable.
|
I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label. |
ghost
added
the
community-contribution
stephentoub
reviewed
Feb 8, 2022
Member
stephentoub
left a comment
stephentoub
left a comment
There was a problem hiding this comment.
Thanks. The changes overall look good, but there are some test failures to be looked at around corner case error handling.
danmoseley
reviewed
Feb 8, 2022
Contributor
Author
|
Tests seem to pass @stephentoub. |
|
Tagging subscribers to this area: @dotnet/area-system-runtime Issue DetailsThe character array overload calls the ReadOnlySpan overload, and the overloads of primitives call a private helper function that takes advantage of ISpanFormattable. Salvaged from #58907.
|
tannergooding
approved these changes
Feb 10, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The character array overload calls the ReadOnlySpan overload, and the overloads of primitives call a private helper function that takes advantage of ISpanFormattable.
Salvaged from #58907.