Skip to content

Remove an allocation importing symmetric keys #64584

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
bartonjs merged 2 commits into from
Feb 1, 2022
Merged

Remove an allocation importing symmetric keys #64584

bartonjs merged 2 commits into from
Feb 1, 2022

Conversation

@vcsjones
Copy link
Member

@vcsjones vcsjones commented Feb 1, 2022

This makes a small improvement to importing symmetric encryption keys.

Method Job Toolchain DataSize Mode Algorithm Mean Error StdDev Ratio RatioSD Gen 0 Gen 1 Gen 2 Allocated
Encrypt_Cbc_ToSpan Job-LHKAOV branch 16 None Internal.Cryptography.AesImplementation 631.5 ns 12.63 ns 11.20 ns 0.98 0.04 0.0439 - - 184 B
Encrypt_Cbc_ToSpan Job-TGELHQ main 16 None Internal.Cryptography.AesImplementation 639.1 ns 12.67 ns 18.17 ns 1.00 0.00 0.0610 - - 256 B

@ghost
Copy link

ghost commented Feb 1, 2022

I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label.

@ghost ghost added the community-contribution Indicates that the PR has been added by a community member label Feb 1, 2022
@ghost
Copy link

ghost commented Feb 1, 2022

Tagging subscribers to this area: @dotnet/area-system-security, @vcsjones
See info in area-owners.md if you want to be subscribed.

Issue Details

This makes a small improvement to importing symmetric encryption keys.

Method Job Toolchain DataSize Mode Algorithm Mean Error StdDev Ratio RatioSD Gen 0 Gen 1 Gen 2 Allocated
Encrypt_Cbc_ToSpan Job-LHKAOV branch 16 None Internal.Cryptography.AesImplementation 631.5 ns 12.63 ns 11.20 ns 0.98 0.04 0.0439 - - 184 B
Encrypt_Cbc_ToSpan Job-TGELHQ main 16 None Internal.Cryptography.AesImplementation 639.1 ns 12.67 ns 18.17 ns 1.00 0.00 0.0610 - - 256 B
Author: vcsjones
Assignees: -
Labels:

area-System.Security, community-contribution
Milestone: -

@bartonjs bartonjs merged commit ef0e1a9 into dotnet:main Feb 1, 2022
@vcsjones vcsjones deleted the import-key-stackalloc branch February 1, 2022 17:10
@ghost ghost locked as resolved and limited conversation to collaborators Mar 3, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@bartonjs bartonjs bartonjs approved these changes

Assignees

No one assigned

Labels

area-System.Security community-contribution Indicates that the PR has been added by a community member

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@vcsjones @bartonjs