Mark Regex source generator Go override as SkipLocalsInit if possible #63277
Conversation
It can have so many locals that zero-initing is measurable.
stephentoub
added
area-System.Text.RegularExpressions
tenet-performance
ghost
assigned
|
Tagging subscribers to this area: @dotnet/area-system-text-regularexpressions Issue DetailsIt can have so many locals that zero-initing is measurable.
|
| return ImmutableArray.Create(Diagnostic.Create(DiagnosticDescriptors.LimitedSourceGeneration, rm.MethodSyntax.GetLocation())); | ||
| } | ||
|
|
||
| bool allowUnsafe = compilation.Options is CSharpCompilationOptions { AllowUnsafe: true }; |
There was a problem hiding this comment.
if all we use from compilation is this check, is it better to just pass the bool from the generator or do you expect us to use the Compilation object for something else?
There was a problem hiding this comment.
As long as we're passing something, seemed like we might as well pass around the Compilation in case we need anything more from it later.
joperezr
left a comment
joperezr
left a comment
There was a problem hiding this comment.
LGTM. Isn't this something that the Compiled engine can benefit from?
I don't believe it's relevant to dynamic methods. |
2 participants
It can have so many locals that zero-initing is measurable.