[mono][wasm] Allow methods with finally clauses to be AOTed. #63065
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vargaz
requested review from
BrzVlad,
EgorBo,
SamMonoRT,
imhameed,
lambdageek,
marek-safar and
thaystg
as code owners
|
I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label. |
ghost
assigned
Contributor
Author
|
/azp run runtime-manual |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Member
|
Not sure if this is related, but in CoreCLR we try to clone "finally" block for the exception-free case: so I guess it can help to avoid falling back to interpreter in most cases |
Contributor
Author
|
This PR only runs finally blocks with the interpreter during exception handling, the normal case runs them using AOT. |
Contributor
Author
|
/azp run runtime-manual |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
Author
|
The remaining WASM failures all look like an OOM while AOTing Microsoft.CodeAnalysis.CSharp.dll. |
Contributor
Author
|
/azp run runtime-manual |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
Author
|
/azp run runtime-manual |
|
Azure Pipelines successfully started running 1 pipeline(s). |
vargaz
force-pushed
the
deopt2
branch
2 times, most recently
from
b537b76 to
bfc524b
Compare
This is implemented by running the finally clause with the interpreter. Methods with clauses have additional code generated, which: * Saves the IL state (pc+arguments+locals) into a MonoMethodILState structure. * Pushes an LMF frame on the LMF stack of type MONO_LMFEXT_IL_STATE. The LMF frame points to the il state. During EH, if such an LMF frame is found, and the IL pc in the il state points inside a clause, then an interpreted version of the method is created, and the finally clause is ran using the interpreter using the il state as the starting state.
Contributor
Author
|
/azp run runtime-manual |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
Author
|
Failures are unrelated. |
BrzVlad
approved these changes
Jan 3, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is implemented by running the finally clause with the interpreter.
Methods with clauses have additional code generated, which:
structure.
The LMF frame points to the il state.
During EH, if such an LMF frame is found, and the IL pc in the
il state points inside a clause, then an interpreted version
of the method is created, and the finally clause is ran using
the interpreter using the il state as the starting state.