Skip to content

Conversation

@naricc
Copy link
Contributor

@naricc naricc commented Dec 14, 2021

This partially reverts this change: #62652

The problem is that although we no longer need to patch, we do need corerun from the clr.hosts subset. Corerun still ends up as part of the pubished clr product artifact, and not in the mono product artifact. And thus we still end up downloading clr, and still need this dependency for now.

@ghost
Copy link

ghost commented Dec 14, 2021

Tagging subscribers to this area: @dotnet/runtime-infrastructure
See info in area-owners.md if you want to be subscribed.

Issue Details

This partially reverts this change: #62652

The problem is that although we no longer need to patch, we do need corerun from the clr.hosts subset. Corerun still ends up as part of the pubished clr product artifact, and not in the mono product artifact. And thus we still end up downloading clr, and still need this dependency for now.

Author: naricc
Assignees: -
Labels:

area-Infrastructure

Milestone: -

Copy link
Member

@lambdageek lambdageek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@safern
Copy link
Member

safern commented Dec 14, 2021

Why not publish it as part of the mono artifacts? Is it because of the artifacts layout structure? I guess it doesn't make sense to invest on that since we are going to collapse the jobs?

@naricc
Copy link
Contributor Author

naricc commented Dec 14, 2021

@safern I was going to try to publish it as part of mono's artifacts, but I looked at the yml files and didn't immediately understand how to do that. So I was going to do this revert while I figure it out.

Any pointers on what needs to change? Is it easy?

@lambdageek
Copy link
Member

Why not publish it as part of the mono artifacts? Is it because of the artifacts layout structure? I guess it doesn't make sense to invest on that since we are going to collapse the jobs?

Yea, the ArchiveFiles azdo task seems to want a single root folder. So we'd have to arrange for corerun to end up in artifacts/mono/OS.Arch.Config/ which didn't seem worth it in the short term.

@lambdageek lambdageek merged commit b635536 into dotnet:main Dec 15, 2021
@ghost ghost locked as resolved and limited conversation to collaborators Jan 14, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants