Populate NativeAOT sources from runtimelab #62611
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label. |
jkotas
approved these changes
Dec 9, 2021
jkotas
reviewed
Dec 9, 2021
| { | ||
| internal unsafe partial class Sys | ||
| { | ||
| [DllImport(Libraries.SystemNative, EntryPoint = "SystemNative_RuntimeThread_CreateThread")] |
Member
There was a problem hiding this comment.
This name looks odd. It should be just SystemNative_CreateThread.
Member
Author
There was a problem hiding this comment.
That one is in flight in #62571. I would rather not do renaming before we have things building and did at least a single integration back to runtimelab (just in case we need the NuGet packages from there in the next couple weeks).
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These should have been part of #62563 but I forgot to look into diffs in libraries/Common. Oh well.