Skip to content

Conversation

@maraf
Copy link
Member

@maraf maraf commented Dec 7, 2021

Integrates Xharness change from dotnet/xharness#790.

Optimize waiting on tests to finish in ThreadlessXunitTestRunner.
Instead of while loop with checking on ManualResetEvent every 1ms,
use TaskCompletionSource triggered from DelegatingExecutionSummarySink completed callback.

@maraf maraf added the arch-wasm WebAssembly architecture label Dec 7, 2021
@maraf maraf added this to the 7.0.0 milestone Dec 7, 2021
@ghost
Copy link

ghost commented Dec 7, 2021

I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label.

@ghost
Copy link

ghost commented Dec 7, 2021

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details

WIP

Author: maraf
Assignees: -
Labels:

arch-wasm

Milestone: 7.0.0

@pavelsavara
Copy link
Member

/azp run runtime-manual

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@maraf maraf marked this pull request as ready for review December 8, 2021 16:20
@maraf maraf requested a review from pavelsavara December 8, 2021 16:21
@pavelsavara pavelsavara requested a review from premun December 8, 2021 17:15
@premun
Copy link
Member

premun commented Dec 9, 2021

I think the failures in the runtime-manual pipeline are not related and we could merge on red for that pipeline (e.g. cryptography tests are failing on Android for some time now)

@maraf maraf merged commit b56ab20 into dotnet:main Dec 9, 2021
@maraf maraf deleted the XharnessAwaitTestResults branch December 9, 2021 10:24
@ghost ghost locked as resolved and limited conversation to collaborators Jan 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

arch-wasm WebAssembly architecture

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants