More stack overflow avoidance in regex NonBacktracking #60786
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove unused Restrict methods instead of adding avoidance. Co-authored-by: Stephen Toub <[email protected]>
This follows a full audit of the NonBacktracking code.
ghost
added
area-System.Text.RegularExpressions
community-contribution
|
Tagging subscribers to this area: @eerhardt, @dotnet/area-system-text-regularexpressions Issue DetailsThis adds more stack overflow avoidance to regex NonBacktracking's recursive algorithms. This includes all the fixes from dotnet/runtimelab#1662 plus additional ones found in a full audit we did with @veanes.
|
Member
|
@olsaarik is it feasible to craft tests that hit some or all of these? otherwise the protection might "rot" during maintenance or feature work in future. |
stephentoub
reviewed
Oct 23, 2021
....RegularExpressions/src/System/Text/RegularExpressions/Symbolic/Algebras/MintermGenerator.cs
Outdated
Show resolved
Hide resolved
stephentoub
reviewed
Oct 23, 2021
....RegularExpressions/src/System/Text/RegularExpressions/Symbolic/Algebras/MintermGenerator.cs
Outdated
Show resolved
Hide resolved
stephentoub
reviewed
Oct 23, 2021
....RegularExpressions/src/System/Text/RegularExpressions/Symbolic/Algebras/MintermGenerator.cs
Outdated
Show resolved
Hide resolved
stephentoub
reviewed
Oct 23, 2021
...gularExpressions/src/System/Text/RegularExpressions/Symbolic/RegexNodeToSymbolicConverter.cs
Outdated
Show resolved
Hide resolved
stephentoub
reviewed
Oct 23, 2021
....Text.RegularExpressions/src/System/Text/RegularExpressions/Symbolic/SymbolicRegexBuilder.cs
Outdated
Show resolved
Hide resolved
stephentoub
reviewed
Oct 23, 2021
...tem.Text.RegularExpressions/src/System/Text/RegularExpressions/Symbolic/SymbolicRegexNode.cs
Outdated
Show resolved
Hide resolved
stephentoub
reviewed
Oct 23, 2021
...tem.Text.RegularExpressions/src/System/Text/RegularExpressions/Symbolic/SymbolicRegexNode.cs
Outdated
Show resolved
Hide resolved
stephentoub
reviewed
Oct 23, 2021
...tem.Text.RegularExpressions/src/System/Text/RegularExpressions/Symbolic/SymbolicRegexNode.cs
Outdated
Show resolved
Hide resolved
stephentoub
reviewed
Oct 23, 2021
...tem.Text.RegularExpressions/src/System/Text/RegularExpressions/Symbolic/SymbolicRegexNode.cs
Outdated
Show resolved
Hide resolved
stephentoub
reviewed
Oct 23, 2021
...tem.Text.RegularExpressions/src/System/Text/RegularExpressions/Symbolic/SymbolicRegexNode.cs
Outdated
Show resolved
Hide resolved
stephentoub
reviewed
Oct 23, 2021
...tem.Text.RegularExpressions/src/System/Text/RegularExpressions/Symbolic/SymbolicRegexNode.cs
Outdated
Show resolved
Hide resolved
stephentoub
reviewed
Oct 23, 2021
...tem.Text.RegularExpressions/src/System/Text/RegularExpressions/Symbolic/SymbolicRegexNode.cs
Outdated
Show resolved
Hide resolved
stephentoub
reviewed
Oct 23, 2021
...tem.Text.RegularExpressions/src/System/Text/RegularExpressions/Symbolic/SymbolicRegexNode.cs
Outdated
Show resolved
Hide resolved
stephentoub
reviewed
Oct 23, 2021
...ystem.Text.RegularExpressions/src/System/Text/RegularExpressions/Symbolic/TransitionRegex.cs
Outdated
Show resolved
Hide resolved
stephentoub
reviewed
Oct 23, 2021
...ystem.Text.RegularExpressions/src/System/Text/RegularExpressions/Symbolic/TransitionRegex.cs
Outdated
Show resolved
Hide resolved
stephentoub
reviewed
Oct 23, 2021
...ystem.Text.RegularExpressions/src/System/Text/RegularExpressions/Symbolic/TransitionRegex.cs
Outdated
Show resolved
Hide resolved
stephentoub
reviewed
Oct 23, 2021
...ystem.Text.RegularExpressions/src/System/Text/RegularExpressions/Symbolic/TransitionRegex.cs
Outdated
Show resolved
Hide resolved
stephentoub
approved these changes
Oct 24, 2021
Member
stephentoub
left a comment
stephentoub
left a comment
There was a problem hiding this comment.
We should add more depth tests for deep expressions, but that can be done separately.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds more stack overflow avoidance to regex NonBacktracking's recursive algorithms. This includes all the fixes from dotnet/runtimelab#1662 plus additional ones found in a full audit we did with @veanes.
Restrictin SymbolicRegexNode and SymbolicRegexSet would've required it too, but they turned out to be dead code, so were removed.