JIT: fix register arg size computation for OSR #59789
Conversation
OSR methods must do special setups for register parameters, loading them from the original method's frame. Update the computation we do here so it works for TYP_STRUCT register params. Closes dotnet#59875.
ghost
added
the
area-CodeGen-coreclr
|
Tagging subscribers to this area: @JulieLeeMSFT Issue DetailsOSR methods must do special setups for register parameters, loading them Closes #59875.
|
|
cc @dotnet/jit-contrib |
|
/azp run runtime-jit-experimental |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
OSR stress R2R tests are all failing with various internal errors. Same failures are there in last weekend's runs so it must be some other problem |
|
/azp run runtime-jit-experimental |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
The crossgen2 test failure is the same issue, it's just cropping up in the dotnet used to run crossgen2, which is currently 6.0.100-rc.1.21430.12. That is, we're running crossgen2 under OSR stress, using an older version of the jit, that still has this bug. Running the test where the crossgen2 is an updated corerun passes. So this will fix itself eventually, once we update that set of bits. |
3 participants
OSR methods must do special setups for register parameters, loading them
from the original method's frame. Update the computation we do here so it
works for TYP_STRUCT register params.
Closes #59875.