EmccCompile: reduce allowedParallelism by 1, to account for the implicit core #59244
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
radical
commented
Sep 17, 2021
radical
commented
- just trying
|
I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label. |
zlatanov
pushed a commit
to zlatanov/runtime
that referenced
this pull request
Sep 17, 2021
radical
force-pushed
the
stj-source-gen
branch
from
259718b to
8c0d944
Compare
Previously, variables holding GC refs were marked volatile so they were loaded/stored to the C stack on every access. Since the stack is conservatively scanned, all the objects pointed to by it are pinned, so there is no need to load them on every access. Instead of marking them as volatile, allocate a 'gc pinning' area on the stack, and store ref variables to it after they are assigned. This improves code size and performance.
Member
|
@vargaz doesn't look like the gc change resolved things |
Member
Author
It did. The build seems to complete, and I think it's then failing because of a typo in my patch. Trying to fix that now. |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.