Fix an issue with ILStripping mscorlib.dll #58934
Conversation
We considered mscorlib.dll as the "core" assembly instead of System.Private.CoreLib.dll which meant Cecil hit an issue while resolving types in it. This only happened when the IL Linker was not being used since it'd have removed the mscorlib.dll facade. Brings in dotnet#58764
|
I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label. |
|
Tagging subscribers to this area: @directhex Issue DetailsWe considered mscorlib.dll as the "core" assembly instead of System.Private.CoreLib.dll which meant Cecil hit an issue while resolving types in it. Brings in #58764
|
|
@akoeplinger your manual updates of just this dependency from runtime-assets are causing merge conflicts with the maestro PRs. Can you consider doing a full runtime-assets update when you make these changes? It should make things auto-resolve. |
|
@ericstj sure :) |
|
Thank you 🙏 |
ghost
locked as resolved and limited conversation to collaborators
4 participants
We considered mscorlib.dll as the "core" assembly instead of System.Private.CoreLib.dll which meant Cecil hit an issue while resolving types in it.
This only happened when the IL Linker was not being used since it'd have removed the mscorlib.dll facade.
Brings in dotnet/runtime-assets#176