Skip to content

Conversation

@directhex
Copy link
Contributor

We have four classes of symbols missing at VS insertion, according to validation:

  • tasks - we were producing ppdb's but not packaging them in the .symbols.nuget, this PR addresses that
  • wasm tasks - we are already producing and shipping ppdb's, implies an issue with ppdb->pdb conversion affecting insertion
  • mono-aot-cross.exe - we were not producing pdb's, this PR addresses that
  • llvm (llc and opt) - we need to get the pdb's from the llvm-project repo build (if indeed we produce them) into this one

Submitting a PR to see if my changes broke the build.

@ghost
Copy link

ghost commented Sep 9, 2021

I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label.

@directhex
Copy link
Contributor Author

There are still some gaps in this, but it should definitely improve matters.

Private build: https://dev.azure.com/dnceng/internal/_build/results?buildId=1361044&view=results

@directhex directhex merged commit cac028c into dotnet:main Sep 15, 2021
@directhex
Copy link
Contributor Author

/backport to release/6.0

@github-actions
Copy link
Contributor

@steveisok
Copy link
Member

/backport to release/6.0-rc2

@github-actions
Copy link
Contributor

@ghost ghost locked as resolved and limited conversation to collaborators Nov 3, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants