-
Notifications
You must be signed in to change notification settings - Fork 5.3k
Change PKCS12 password to assist with credscan #58807
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Tagging subscribers to this area: @bartonjs, @vcsjones, @krwq, @GrabYourPitchforks Issue Details/cc @aik-jahoda
|
|
Converting to draft because apparently the password was supposed to be PLACEHOLDER. Will change it again. |
|
If we already have it suppressed, why are we changing it? Does the new PKCS12 use the same encryption and MAC parameters, or are we possibly losing some edge coverage on DSA? |
I got an email I should change it. I'm guessing the comment suppression wasn't enough and there maybe needed to be another above the .ctor for
Yes. Same PBE parameters, same key (DSA). Just changing the PBE password. |
|
The problem is not in the certificate itself, but with It complains about plaintext password. We decided to prefer PLACEHOLDER as a safe well known "password" which at first sight confirm it is test only password. |
aik-jahoda
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
/backport to release/6.0 |
|
Started backporting to release/6.0: https://github.com/dotnet/runtime/actions/runs/1233560600 |
/cc @aik-jahoda