[release/6.0] Fix trim_youngest_desired #58538
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ain memory - the return value should never be larger than total_new_allocation.
ghost
added
the
|
Tagging subscribers to this area: @dotnet/gc Issue DetailsBackport of #58180 to release/6.0 /cc @PeterSolMS Customer ImpactTestingRisk
|
jeffschwMSFT
approved these changes
Sep 2, 2021
Member
jeffschwMSFT
left a comment
jeffschwMSFT
left a comment
There was a problem hiding this comment.
Approved. Please get a code review and then we can merge.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #58180 to release/6.0
/cc @PeterSolMS
Customer Impact
We have traces from a customer that show gen 0 budget shooting up abruptly to 5.1 GB and back. As this is happening in a high memory situation, it is an issue that needs fixing.
Testing
Verified in the debugger that the proposed fix does indeed take of the issue. The fix has been in the 7.0 branch for almost a week with no issues reported.
Risk
Risk is low because there is no change in behavior unless there is severe memory pressure. If there is severe memory pressure, then the application will be using significantly less memory than without the change, which should be beneficial.