[debugger] Avoid calling debugger_agent_single_step_from_context when thread is not attached yet #58467
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tagging subscribers to this area: @thaystg Issue DetailsSpecial thanks to @lambdageek for helping me with this PR.
|
lambdageek
reviewed
Sep 1, 2021
| WrapperInfo *info = mono_marshal_get_wrapper_info (method); | ||
| if (info->subtype == WRAPPER_SUBTYPE_INTERP_IN) { | ||
| /* We could hit a seq point before attaching to the JIT (#8338) */ | ||
| seq_points = FALSE; |
Member
There was a problem hiding this comment.
lambdageek
approved these changes
Sep 1, 2021
Member
|
/backport to release/6.0-rc1 |
Contributor
|
Started backporting to release/6.0-rc1: https://github.com/dotnet/runtime/actions/runs/1188329900 |
Redth
pushed a commit
to dotnet/maui
that referenced
this pull request
Sep 1, 2021
Blazor android projects (and possibly iOS?) will require this runtime fix: dotnet/runtime#58467 So, enabling interpreter again on non-blazor templates
rmarinho
pushed a commit
to dotnet/maui
that referenced
this pull request
Sep 1, 2021
* Update OutputType to WinExe on -windows This happens in the sdk targets/props but not quite early enough to influence the `EnableWin32Codegen` property which causes `[STAThreadAttribute]` to be generated in the Windows app. * For non-blazor projects, interpreter is fine Blazor android projects (and possibly iOS?) will require this runtime fix: dotnet/runtime#58467 So, enabling interpreter again on non-blazor templates
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://devdiv.visualstudio.com/DevDiv/_workitems/edit/1383962
This happens because a WebView embedded in an Android app can call back into the runtime on a native thread that the runtime has not seen before. The callback goes through a wrapper method. The wrapper method is responsible for registering the thread with the runtime. We were incorrectly inserting debugger sequence points in the wrapper method. As a result, if the debugger begins a suspend (which turns on single stepping - which relies on sequence points), the unregistered thread would call back to the debugger which would crash because we have no info about the thread.