Fix X509ChainElementCollection_CopyTo_NonZeroLowerBound_ThrowsIndexOutOfRangeException test on Android #58441
Conversation
…tOfRangeException test on Android It started to fail because the validity of the MicrosoftDotComSslCertBytes expired on 2021-08-29 22:17:02. Since this test doesn't need to validate a specific expiration time we can just set the VerificationTime on the chain like we do in other tests. Fixes dotnet#58416
|
Tagging subscribers to this area: @bartonjs, @vcsjones, @krwq, @GrabYourPitchforks Issue DetailsIt started to fail because the validity of the MicrosoftDotComSslCertBytes expired on 2021-08-29 22:17:02. Fixes #58416
|
|
Why is it affecting Android specifically? |
|
JSON tests failed with heap corruption? |
Because Android's chain builder has OS specific behavior. Other platforms, with an expired certificate, will at least build the chain and we get the chain back, plus an "it's expired" flag. Android does not bother to build a chain for a an expired cert, it immediately bails out. So we don't get the chain collection back (thus the exception) |
|
/backport to release/6.0 |
|
Started backporting to release/6.0: https://github.com/dotnet/runtime/actions/runs/1189440242 |
ghost
locked as resolved and limited conversation to collaborators
5 participants
It started to fail because the validity of the MicrosoftDotComSslCertBytes expired on 2021-08-29 22:17:02Z.
Since this test doesn't need to validate a specific expiration time we can just set the VerificationTime on the chain like we do in other tests.
Fixes #58416