Pass a null getter\setter with [JsonIgnore] and src gen #58405
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tagging subscribers to this area: @eiriktsarpalis, @layomia Issue DetailsAddresses #58320 Expected to port to 6.0.
|
stephentoub
approved these changes
Sep 1, 2021
|
|
||
| string getterNamedArg = memberMetadata.CanUseGetter | ||
| string getterNamedArg = memberMetadata.CanUseGetter && | ||
| memberMetadata.DefaultIgnoreCondition != JsonIgnoreCondition.Always |
Member
There was a problem hiding this comment.
Curious, how does the presence of ObsoleteAttribute influence the value of memberMetadata.DefaultIgnoreCondition?
Contributor
Author
There was a problem hiding this comment.
In the issue this generated code is shown:
getter: static (obj) => ((global::MyLibrary.Models.ClassA)obj).Foo,
setter: static (obj, value) => ((global::MyLibrary.Models.ClassA)obj).Foo = value!,Since the property Foo is used but obsolete it generates a compiler warning.
eiriktsarpalis
approved these changes
Sep 1, 2021
Contributor
Author
|
/backport to release/6.0 |
Contributor
|
Started backporting to release/6.0: https://github.com/dotnet/runtime/actions/runs/1195045466 |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #58320
Expected to port to 6.0.